Arthur de Jong

Open Source / Free Software developer

summaryrefslogtreecommitdiffstats
path: root/stdnum/do
Commit message (Collapse)AuthorAgeFilesLines
* Fix typos found by codespellDimitri Papadopoulos2021-08-101-1/+1
| | | | Closes https://github.com/arthurdejong/python-stdnum/pull/269
* Add new e-CF types to Dominican Republic NCFFRANK ROBERTO CHAVEZ SOSA2021-07-181-0/+2
|
* Fix parsing of empty fields in DGII checkingAndres Rodriguez2021-07-181-2/+2
|
* Add ENCF validation support for Dominican Republic NCFCristopher Ortega2021-07-181-4/+35
| | | | Closes https://github.com/arthurdejong/python-stdnum/pull/248
* Drop pinning of isort now flake8-isort has been fixedArthur de Jong2021-01-101-1/+1
| | | | | | | This changes a few inline imports in the code to pass with the new isort. Reverts 291b831
* Scape new line characterevaldez892020-08-021-1/+1
| | | | | Closes https://github.com/arthurdejong/python-stdnum/pull/233 Closes https://github.com/arthurdejong/python-stdnum/issues/232
* Use HTTPS in URLs where possibleArthur de Jong2020-03-202-2/+2
|
* Change DGII endpoint to new oneGustavo Valverde2020-02-181-9/+13
| | | | | | The old endpoint has been deprecated. Closes https://github.com/arthurdejong/python-stdnum/pull/190
* Add missing NCF document types for validationGustavo Valverde2020-01-221-1/+3
| | | | | | | | These document types are in the official documentation, but were not being validated: https://dgii.gov.do/cicloContribuyente/facturacion/comprobantesFiscales/Paginas/tiposComprobantes.aspx Closes https://github.com/arthurdejong/python-stdnum/pull/186
* Switch to using lxml for HTML parsingArthur de Jong2019-12-271-13/+12
| | | | | This avoids an extra dependency on BeautifulSoup and makes the code more consistent.
* Fix broken links to DGII documentationJeffry Jesus De La Rosa2019-10-131-2/+2
| | | | | | | DGII has changed its page, all the link have been broken, so they changed some URL. Closes https://github.com/arthurdejong/python-stdnum/pull/153
* Change DGII form parametersJeffry Jesus De La Rosa2019-10-131-3/+7
| | | | | | | | DGII has changed their validation mechanism, so we first exract the __EVENTVALIDATION and __VIEWSTATE from the form and put them in the post request for validation. Closes https://github.com/arthurdejong/python-stdnum/pull/165
* Update Dominican Republic e-CF documents typesJeffry Jesus De La Rosa2019-06-141-6/+18
| | | | | | | The document type values are different from the NCF document types https://dgii.gov.do/contribuyentes/personasFisicas/inicioOperaciones/ComprobantesFiscales/Paginas/comprobantesFiscalesElectronicos.aspx Closes https://github.com/arthurdejong/python-stdnum/pull/138
* Support Dominican Republic e-CF within NCFJeffry Jesus De La Rosa2019-06-141-18/+40
| | | | | | | | e-CF is the new way of DGII document, is the same as NCF, but the difference one to another, is that e-CF has 13 digit and is electronic invoice, with this change it will validate the correct NCF and e-CF. Closes https://github.com/arthurdejong/python-stdnum/pull/135
* Use an internal isdigits() function instead of str.isdigit()Arthur de Jong2019-04-293-7/+7
| | | | | | | | | | | The problem with the latter is that it will also accept all kinds of unicode digits that are not the ASCII 0-9 digits causing all kinds of problems in check digit calculations. Some of these unicode characters are also considered digits by int() but some are not (such as the SUPERSCRIPT TWO unicode character). Closes https://github.com/arthurdejong/python-stdnum/issues/96
* Improvements reported by pylintArthur de Jong2019-02-171-2/+2
|
* Return only first response from DGII lookupAndrés R2019-02-161-1/+2
| | | | | | | This fixes an issue when response for check_dgii() comes with 2 records instead of one for same RNC. Closes https://github.com/arthurdejong/python-stdnum/pull/95
* Use HTTPS for WSDL as HTTP was deprecatedGustavo Valverde2018-11-172-2/+2
| | | | | | | The regulator changed their site to use HTTPS by default; making this resource unavailable through HTTP. Closes https://github.com/arthurdejong/python-stdnum/pull/85
* Switch the NCF online check to the new formArthur de Jong2018-05-191-19/+37
| | | | | | | This tries to screen-scrape the new DGII form that is used to validate the new format of NCF numbers. Closes https://github.com/arthurdejong/python-stdnum/issues/71
* Support new style of NCF numbersArthur de Jong2018-04-091-8/+14
| | | | | | | | | This adds support for validating Dominican Republic invoice numbers that should be used since from 2018-05-01. http://www.dgii.gov.do/contribuyentes/personasFisicas/inicioOperaciones/ComprobantesFiscales/Paginas/SecuenciaDeNCF.aspx Closes https://github.com/arthurdejong/python-stdnum/issues/69
* Add check_dgii() to stdnum.do.cedula moduleArthur de Jong2018-02-191-1/+31
| | | | | | | This exposes the stdnum.do.rnc.check_dgii() in the stdnum.do.cedula module with but rename the rnc result entry to cedula. Closes https://github.com/arthurdejong/python-stdnum/issues/63
* Fix PySimpleSOAP DGII result parsing issueArthur de Jong2018-02-192-3/+9
| | | | | | | | This strips the wrapper that PySimpleSOAP puts around results from the DGII PySimpleSOAP SOAP call. Closes https://github.com/arthurdejong/python-stdnum/issues/64 Closes https://github.com/arthurdejong/python-stdnum/issues/65
* Update the flake8 ignore listArthur de Jong2018-02-141-1/+1
| | | | | | | | | | | | Re-enable the flake8 test for unused imports by explicitly marking imports for namespace purposes. This allows us to remove a few unused imports. A few more cleanups that allow us to reduce the number of ignored flake8 ignored tests. The remaining ignored tests are now documented. Ignore a flake8 warning about print statements because we use print in the update scripts.
* Allow configuring SOAP request timeoutArthur de Jong2018-02-062-11/+12
| | | | | | This adds a timeout parameter to all checks that use a SOAP web service to reduce the blocking time. The default timeout for all checks is 30 seconds.
* Fix Python 2.6 compatibilityArthur de Jong2018-01-012-6/+6
|
* Add stdnum.do.ncf.check_dgii()Arthur de Jong2017-10-221-1/+51
| | | | | | This adds functions for querying the Dirección General de Impuestos Internos (DGII) API to check if the RNC and NCF combination provided is valid.
* Add stdnum.do.rnc.check_dgii() and search_dgii()Arthur de Jong2017-10-221-1/+100
| | | | | | This adds functions for querying the Dirección General de Impuestos Internos (DGII) API to validate the RNC and search the register by keyword.
* Add Dominican Republic receipt number (NCF)Arthur de Jong2017-10-221-0/+82
| | | | | This number does not have a check digit but uses a distinctive enough format that it should not be too great of a problem.
* Also add a whitelist for Dominican Republic RNCArthur de Jong2017-10-141-3/+14
| | | | | | Some RNCs are apparently valid while having an incorrect check digit (though most appear to be inactive). There also appear to be valid RNCs that do not have 9 digits.
* Add a few new numbers to the Cedula whitelistArthur de Jong2017-10-141-76/+95
| | | | | | These numbers were found to be valid but had an invalid check digit nonetheless (though most appear to be inactive). Also there appear to be a few valid Cedula that do not have 11 digits.
* Make import ordering consistentArthur de Jong2017-09-111-1/+1
|
* Docstring improvementsArthur de Jong2017-09-112-6/+6
|
* Use zip() instead of enumerate()Arthur de Jong2015-10-051-1/+1
| | | | Makes the code slightly simpler and more compact.
* Extend the list of valid CedulaArthur de Jong2015-04-231-84/+80
| | | | | | This is based on the list of Cedula found at http://prd.org.do/2013/07/30/lista-del-cen-del-prd-actualizada-y-registrada-en-la-junta-central-electoral/ (link provided by José Arturo García)
* Add Dominican Republic Cedula numberArthur de Jong2015-04-221-0/+160
| | | | | | | | | The Cedule is a Dominican Republic national identification number for persons. The number uses the Luhn checksum but apparently there are a lof of valid numbers in use that do not match the checksum. For this a whitelist is used.
* Add Dominican Republic RNC numberArthur de Jong2015-04-222-0/+102
The RNC (Registro Nacional del Contribuyente) is the Dominican Republic taxpayer registration number for companies.