Arthur de Jong

Open Source / Free Software developer

summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArthur de Jong <arthur@arthurdejong.org>2011-12-10 23:17:33 +0100
committerArthur de Jong <arthur@arthurdejong.org>2011-12-10 23:17:33 +0100
commitf4b3ad848987eb6ac2cf50d7ea99d1a7b579c70c (patch)
tree08c1b962d1d920a76b1dd0d60428aab5077ddb47
parent0e707ad52f990aa951bced9a680d14d8162336f0 (diff)
properly log failures to lookup DNS SRV records
git-svn-id: http://arthurdejong.org/svn/nss-pam-ldapd/nss-pam-ldapd@1569 ef36b2f9-881f-0410-afb5-c4e39611909c
-rw-r--r--nslcd/cfg.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/nslcd/cfg.c b/nslcd/cfg.c
index e5c3b1a..ab1bb1f 100644
--- a/nslcd/cfg.c
+++ b/nslcd/cfg.c
@@ -192,7 +192,12 @@ static void add_uris_from_dns(const char *filename,int lnr,
char buf[HOST_NAME_MAX+sizeof("ldap://")];
log_log(LOG_DEBUG,"query %s for SRV records",domain);
rc=ldap_domain2hostlist(domain,&hostlist);
- /* FIXME: have better error handling */
+ if (rc!=LDAP_SUCCESS)
+ {
+ log_log(LOG_ERR,"%s:%d: no servers found in DNS zone %s: %s",
+ filename,lnr,domain,ldap_err2string(rc));
+ exit(EXIT_FAILURE);
+ }
if ((hostlist==NULL)||(*hostlist=='\0'))
{
log_log(LOG_ERR,"%s:%d: no servers found in DNS zone %s",filename,lnr,domain);