From d3c6a66ac3b76b571fcb2377b0edf41c4c67a4d5 Mon Sep 17 00:00:00 2001
From: Arthur de Jong <arthur@arthurdejong.org>
Date: Fri, 12 Apr 2013 09:56:49 +0200
Subject: Raise an error with a missing old password on password modification

---
 pynslcd/pam.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'pynslcd/pam.py')

diff --git a/pynslcd/pam.py b/pynslcd/pam.py
index 2d0944c..1dbf7e8 100644
--- a/pynslcd/pam.py
+++ b/pynslcd/pam.py
@@ -283,8 +283,10 @@ class PAMPasswordModificationRequest(PAMRequest):
             # check if rootpwmodpw should be used
             if not parameters['oldpassword'] and self.calleruid == 0 and cfg.rootpwmoddn:
                 password = cfg.rootpwmoddn
-            else:
+            elif parameters['oldpassword']:
                 password = parameters['oldpassword']
+            else:
+                raise ValueError('password missing')
         else:
             binddn = parameters['userdn']
             password = parameters['oldpassword']
-- 
cgit v1.2.3